So I recently decided to try out some good luck and weather spells, and every spell I try just isn't working! I am following all the instructions and nothing is working. Am I still doing something wrong?
As has already been mentioned, most people believe weather control to be out of our control, it is too big a system to change.
Also, the article posted is really useful for identifying the reasons spells don't work, the biggest of which is often that you haven't studied enough for them to work. Following the instructions isn't enough, you need to understand basic practices, understand the energies that you are working with before spells will work successfully.
Along with lack of knowledge a spell may not work because it cannot work, such as teleportation spells, or instant money spells, they simply aren't possible.
Other than that a spell may not work because it isn't meant to work, it may not be the right time or you haven't given it enough time to work. Spells aren't instant, they can take days, weeks, months, sometimes even years for the effects to manifest, so your spells may have worked, you just haven't seen the effects of said spells, yet.