well, why do you have each item?
a picture of the two of you together is a fine idea, but why tie it with string? [i know, to bind you together, but i wouldn't because that could come back to bite you. a picture of a happy memory is all you need]
why the cinnamon? [personally i add cinnamon to everything because it works well for me] i would go with cinnamon sticks only, i wouldn't add cinnamon oil and cinnamon powder, you already have cinnamon. if you had to choose one go with the powder as it would be 'purer' than the oil.
boxer shorts and his sock, as with the cinnamon, pick one [boxers would be better imo] you've already personalized it with one item, a second doesn't make it extra personalized [... unless you use his blood, hair, spit, so on. but i don't recommend ripping chunks of your ex's hair out for a spell]
a blue and pink candle? [i get it, blue for boy pink for girl] you already have a photo of the two of you, so the coloured candle you are placing on top of the jar is typically used to add power from the corresponding colour, not a boyfriend and girlfriend represented in candle form [again, the photo plays that role] i would go with pink or red since you want to spark love.
another thing i would change is i wouldn't use oil in the jar, i prefer using herbs in the jar and using the oil to either anoint the herbs/photo/clothing or the candle. [and again, cinnamon oil, rosewood oil, and love me oil? overkill my friend. use the love me oil and sub out cinnamon powder and a red rose petals instead]
personally i would light the candle for a couple minutes every night from the new to full moon [letting the candle burn out on the full moon] each time you light the candle recite the chant [if there is any] and visualize the two of you together again.
now, one other point, you should probably reflect on why you broke up in the first place so you can understand why and how to resolve the issue, so if you do get back together history will not repeat itself. also, the spell most likely will not make him walk over to you and go 'all is forgiven, we're dating again!' keep an eye out for subtle hints, become friendly with him again, and when the time feels right, calmly talk with him.